[
https://issues.apache.org/jira/browse/PROTON-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17174197#comment-17174197
]
Robbie Gemmell commented on PROTON-2255:
----------------------------------------
If you set an the bytes-based 'session capacity' explicitly, there isnt really
a choice but to recalculate the incoming window precisely at some point, its
simply how it has to work since the window is frame based. There are different
ways of doing it but at the point of flow, when the information has to be sent,
is perhaps the least frequent and simplest way of doing it. If you are setting
32TB capacities to provoke very large windows (which would be used anyway if
you didnt set the capacity) then yes it is almost certainly a waste of time,
though its probably not that significant given what it does to work out the
value.
> [proton-c] unexpected incoming-window in begin frame when running Dispatch
> test in 32 bit system
> ------------------------------------------------------------------------------------------------
>
> Key: PROTON-2255
> URL: https://issues.apache.org/jira/browse/PROTON-2255
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c
> Affects Versions: proton-c-0.31.0
> Reporter: Ganesh Murthy
> Priority: Major
>
> system_tests_protocol_settings fails in Dispatch with the following error
>
> {noformat}
> ======================================================================
> FAIL: test_connector_default
> (system_tests_protocol_settings.ConnectorSettingsDefaultTest)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File
> "/home/jenkins/workspace/rh-qpid-dispatch-dist-el6-32-master/build/BUILD/qpid-dispatch-1.13.0/tests/system_tests_protocol_settings.py",
> line 343, in test_connector_default
> self.assertTrue(" incoming-window=2147483647," in begin_lines[0])
> AssertionError: False is not True
> ======================================================================
> FAIL: test_max_frame_max_session_zero
> (system_tests_protocol_settings.MaxFrameMaxSessionFramesZeroTest)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File
> "/home/jenkins/workspace/rh-qpid-dispatch-dist-el6-32-master/build/BUILD/qpid-dispatch-1.13.0/tests/system_tests_protocol_settings.py",
> line 287, in test_max_frame_max_session_zero
> self.assertTrue(" incoming-window=2147483647," in begin_lines[0])
> AssertionError: False is not True
> ======================================================================
> FAIL: test_max_session_frames_default
> (system_tests_protocol_settings.MaxSessionFramesDefaultTest)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File
> "/home/jenkins/workspace/rh-qpid-dispatch-dist-el6-32-master/build/BUILD/qpid-dispatch-1.13.0/tests/system_tests_protocol_settings.py",
> line 249, in test_max_session_frames_default
> self.assertTrue(" incoming-window=2147483647," in begin_lines[0])
> AssertionError: False is not True {noformat}
>
> The actual line in the log is
> {noformat}
> 2020-07-30 12:47:53.727396 -0400 PROTOCOL (trace) [3]:FRAME: 0 <-
> @begin(17) [next-outgoing-id=0, incoming-window=131071,
> outgoing-window=2147483647]
> (/root/project/build/BUILD/qpid-dispatch-1.13.0/src/server.c:112) {noformat}
>
> The test is expecting to see the incoming-window to be 2147483647 but instead
> gets 131071.
> This could be a possible issue with the way the incoming-window is logged but
> really not sure.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
