[
https://issues.apache.org/jira/browse/DISPATCH-1751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17198606#comment-17198606
]
ASF GitHub Bot commented on DISPATCH-1751:
------------------------------------------
ChugR opened a new pull request #847:
URL: https://github.com/apache/qpid-dispatch/pull/847
AMQP Open defines a 'max-frame-size'
AMQP Begin defines an 'incoming-window'
Proton allows specification of a session 'capacity'. Initially the
incoming-window will be (capacity / max-frame-size), defining at most
how many max-size transfers will definitely be accepted on the session.
Dispatch listener config defines a maxFrameSize and a maxSessionFrames
the product of which is equal to the capacity to be configured in Proton.
Dispatch vhostUserGroup policy defines a maxFrameSize and a
maxSessionWindow. The maxSessionWindow is passed directly to Proton
as the capacity.
Proton has some rules about values are allowed for max-frame-size and
capacity.
* max-frame-size has a minimum max-value (512 octets)
* on 32-bit systems the capacity cannot exceed 2^31-1
* on 64-bit systems the capacity cannot exceed 2^63-1
This patch
* Defines an AMQP_MAX_WINDOW_SIZE (2^31-1) as used by Proton.
* Cleans up the calculation of Proton session capacity from
the various Dispatch configuration settings.
* If maxSessionFrames is not set, meaning unlimited frames, then
the session capacity sent to Proton is zero. In this case Proton
never calculates an actual incoming-window value and simply
sends AMQP_MAX_WINDOW_SIZE as a hard-coded value for incoming-window.
This is for both 32-bit and 64-bit systems.
* Adjusts some self tests to allow the default settings for 32-bit and
64-bit systems without detecting which bit width is in effect. If
the test detects one or the other value then it calls the test a
success.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> unexpected incoming-window in begin frame when running Dispatch on 32 bit
> system
> --------------------------------------------------------------------------------
>
> Key: DISPATCH-1751
> URL: https://issues.apache.org/jira/browse/DISPATCH-1751
> Project: Qpid Dispatch
> Issue Type: Bug
> Affects Versions: 1.13.0
> Reporter: Ganesh Murthy
> Priority: Major
>
> On 32bit systems, an unexpected incoming-window value is set. This for
> example causes system_tests_protocol_settings failures on 32bit systems, with
> test expecting to see the incoming-window be 2147483647 but instead finding
> it much less, e.g 131071.
> This is due to the way the session capacity is configured, particularly on
> 32bit systems. See more details (output, code, etc) from prior discussions on
> PROTON-2255 (raised when this was incorrectly thought to be a proton issue).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
