[
https://issues.apache.org/jira/browse/PROTON-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17211662#comment-17211662
]
ASF GitHub Bot commented on PROTON-2170:
----------------------------------------
jiridanek commented on a change in pull request #271:
URL: https://github.com/apache/qpid-proton/pull/271#discussion_r502779168
##########
File path: cpp/CMakeLists.txt
##########
@@ -231,90 +231,92 @@ install (FILES
${CMAKE_CURRENT_BINARY_DIR}/ProtonCppConfigVersion.cmake
DESTINATION ${LIB_INSTALL_DIR}/cmake/ProtonCpp)
-set(testdata "${CMAKE_CURRENT_BINARY_DIR}/testdata")
-set(test_env "")
-
-# SASL configuration for tests
-if(CyrusSASL_Saslpasswd_EXECUTABLE)
-
configure_file("${CMAKE_CURRENT_SOURCE_DIR}/testdata/sasl-conf/proton-server.conf.in"
- "${testdata}/sasl-conf/proton-server.conf")
- execute_process(
- COMMAND echo password
- COMMAND ${CyrusSASL_Saslpasswd_EXECUTABLE} -c -p -f
"${testdata}/sasl-conf/proton.sasldb" -u proton user
- RESULT_VARIABLE ret)
- if(ret)
- message(WARNING "${CyrusSASL_Saslpasswd_EXECUTABLE}: error ${ret} - some
SASL tests will be skipped")
- else()
- set(test_env ${test_env} "PN_SASL_CONFIG_PATH=${testdata}/sasl-conf")
+if (BUILD_TESTING)
+ set(testdata "${CMAKE_CURRENT_BINARY_DIR}/testdata")
Review comment:
Adding one level of indentation to these multiple screens of code looks
undesirable. It would be best to factor out all this into its own `tests.cmake`
and conditionally include it here. I'll have to try if/how this works in CMake.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> cmake -DBUILD_TESTING=OFF does not disable building all tests
> -------------------------------------------------------------
>
> Key: PROTON-2170
> URL: https://issues.apache.org/jira/browse/PROTON-2170
> Project: Qpid Proton
> Issue Type: Bug
> Components: build
> Affects Versions: proton-c-0.30.0
> Reporter: Jiri Daněk
> Priority: Major
> Attachments: 0001-CMakeLists.txt-allow-the-user-to-disable-tests.patch
>
>
> Compile as in PROTON-2145, that means
> {noformat}
> mkdir _build
> cd _build
> cmake .. -DCMAKE_INSTALL_PREFIX=/usr/local\
> -DSYSINSTALL_BINDINGS=ON\
> -DBUILD_STATIC_LIBS=ON\
> -DBUILD_TESTING=OFF\
> -DENABLE_FUZZ_TESTING=OFF\
> -DFUZZ_REGRESSION_TESTS=OFF
> make -j4
> make install
> {noformat}
> (leave out -DBUILD_WITH_CXX=ON)
> Despite {{-DBUILD_TESTING=OFF}}, the following is being built
> {noformat}
> [ 42%] Built target test_main
> [ 45%] Built target c-core-test
> [ 45%] Built target c-extra-test
> [ 46%] Built target c-ssl-proactor-test
> [ 47%] Built target c-proactor-test
> [ 65%] Built target interop_test
> [ 65%] Built target credit_test
> [ 65%] Built target reconnect_test
> [ 66%] Built target codec_test
> [ 67%] Built target value_test
> [ 68%] Built target connection_driver_test
> [ 84%] Built target scalar_test
> [ 85%] Built target message_test
> [ 85%] Built target link_test
> [ 86%] Built target container_test
> [ 87%] Built target cpp-test
> [ 88%] Built target map_test
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
