[
https://issues.apache.org/jira/browse/PROTON-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17229042#comment-17229042
]
Clifford Jansen commented on PROTON-2292:
-----------------------------------------
06833ac - re-instated a lock correctly identified as missing by Coverity and
TSAN. The lock did exist during most development and testing but suffered
accidental deletion when debug code was trimmed for checkin. Bleh.
8c8a8bc - TSAN sees a possible collision with mutex use (pni_timer_set) against
mutex destruction (pni_timer_free). This is not actually possible. For
connection timers, set and free are serialized calls from the working context.
For the proactor timer, the free call is bound to pn_proactor_free which is
only valid when all worker threads have stopped proactor work and no competing
calls to any proactor APIs can happen.
Coverity reports two other false positives:
*** CID 363779: Program hangs (ORDER_REVERSAL)
The similarly named context.mutex vars refer to the timer_manager and
pconnection respectively which are separate and cannot produce a deadlock.
*** CID 363843: Concurrent data access violations (MISSING_LOCK)
This is a repeat of of the above TSAN issue. pni_timer_manager_finalize() is
only called by pn_proactor_free(), when there are no competing threads.
> [c] Proactor: TSAN failure in pni_timer_manager
> -----------------------------------------------
>
> Key: PROTON-2292
> URL: https://issues.apache.org/jira/browse/PROTON-2292
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c
> Affects Versions: proton-c-0.33.0
> Reporter: Andrew Stitcher
> Assignee: Clifford Jansen
> Priority: Critical
>
> See Test errors starting at:
> https://travis-ci.org/github/apache/qpid-proton/jobs/742285891#L3018
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
