grs commented on a change in pull request #961: URL: https://github.com/apache/qpid-dispatch/pull/961#discussion_r545020036
########## File path: src/adaptors/http1/http1_server.c ########## @@ -70,6 +70,7 @@ typedef struct _server_request_t { bool request_settled; // set by adaptor bool request_acked; // true if dispo sent to core bool headers_encoded; // True when header encode done + bool response_settled; Review comment: Agreed I have removed that. ########## File path: src/adaptors/http1/http1_client.c ########## @@ -1238,6 +1505,24 @@ uint64_t qdr_http1_client_core_link_deliver(qdr_http1_adaptor_t *adaptor, _client_response_msg_t *rmsg = DEQ_TAIL(hreq->responses); assert(rmsg && rmsg->dlv == delivery); + // when aggregating responses, they are saved on the list until + // the request has been settled, then encoded in the configured + // aggregation format + if (hconn->cfg.aggregation != QD_AGGREGATION_NONE) { + qd_log(qdr_http1_adaptor->log, QD_LOG_DEBUG, "[C%"PRIu64"][L%"PRIu64"] Received response (%i responses received), settling", hconn->conn_id, link->identity, DEQ_SIZE(hreq->responses)); + rmsg->dispo = PN_ACCEPTED; + qd_message_set_send_complete(msg); Review comment: Probably. I have added that check. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org