[
https://issues.apache.org/jira/browse/DISPATCH-1854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17258213#comment-17258213
]
ASF GitHub Bot commented on DISPATCH-1854:
------------------------------------------
ganeshmurthy commented on a change in pull request #962:
URL: https://github.com/apache/qpid-dispatch/pull/962#discussion_r551325693
##########
File path: src/router_core/delivery.c
##########
@@ -503,6 +501,11 @@ void qdr_delivery_link_peers_CT(qdr_delivery_t *in_dlv,
qdr_delivery_t *out_dlv)
if (!in_dlv || !out_dlv)
return;
+ qdr_link_t *link = qdr_delivery_link(in_dlv);
+ if (link) {
+ qd_log(link->core->log, QD_LOG_TRACE, DLV_FMT" :in
qdr_delivery_link_peers_CT out: "DLV_FMT, DLV_ARGS(in_dlv), DLV_ARGS(out_dlv));
Review comment:
Instead of
qd_log(link->core->log, QD_LOG_TRACE, DLV_FMT" :in
qdr_delivery_link_peers_CT out: "DLV_FMT, DLV_ARGS(in_dlv), DLV_ARGS(out_dlv));
can we say
qd_log(link->core->log, QD_LOG_TRACE, DLV_FMT" :in
qdr_delivery_link_peers_CT out_dlv: "DLV_FMT, DLV_ARGS(in_dlv),
DLV_ARGS(out_dlv));
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Delivery id numbers could be added for better log message comprehension
> -----------------------------------------------------------------------
>
> Key: DISPATCH-1854
> URL: https://issues.apache.org/jira/browse/DISPATCH-1854
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Protocol Adaptors, Router Node, Routing Engine
> Affects Versions: 1.14.0
> Reporter: Charles E. Rolke
> Assignee: Charles E. Rolke
> Priority: Major
>
> Deliveries could use id numbers similar to qd_server_t.next_connection_id
> numbers.
> Then the delivery id numbers could be used in places where the qd_delivery_t
> object addresses are printed in logs. This would eliminate the ambiguity with
> the object addresses that get reused.
> The effort to scavenge the extra info for logs could be wrapped in
> qd_log_enabled conditionals so that the work is done only when the log is to
> be printed.
> Where possible log lines with delivery info could be prefixed with
> connection, link, and delivery id numbers like *[C12][L34][D105]*
> Delivery ids could be added to transfer and settlement log lines.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
