[
https://issues.apache.org/jira/browse/PROTON-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17265061#comment-17265061
]
ASF GitHub Bot commented on PROTON-2320:
----------------------------------------
jiridanek commented on a change in pull request #285:
URL: https://github.com/apache/qpid-proton/pull/285#discussion_r557570245
##########
File path: tools/python/mllib/dom.py
##########
@@ -32,285 +32,308 @@
else:
STRING_TYPES = (str,)
+
class Container:
- def __init__(self):
- self.children = []
+ def __init__(self):
+ self.children = []
+
+ def add(self, child):
+ child.parent = self
+ self.children.append(child)
- def add(self, child):
- child.parent = self
- self.children.append(child)
+ def extend(self, children):
+ for child in children:
+ child.parent = self
+ self.children.append(child)
- def extend(self, children):
- for child in children:
- child.parent = self
- self.children.append(child)
class Component:
- def __init__(self):
- self.parent = None
+ def __init__(self):
+ self.parent = None
- def index(self):
- if self.parent:
- return self.parent.children.index(self)
- else:
- return 0
+ def index(self):
+ if self.parent:
+ return self.parent.children.index(self)
+ else:
+ return 0
+
+ def _line(self, file, line, column):
+ self.file = file
+ self.line = line
+ self.column = column
- def _line(self, file, line, column):
- self.file = file
- self.line = line
- self.column = column
class DispatchError(Exception):
- def __init__(self, scope, f):
- msg = "no such attribute"
+ def __init__(self, scope, f):
+ msg = "no such attribute"
+
class Dispatcher:
- def is_type(self, type):
- cls = self
- while cls != None:
- if cls.type == type:
- return True
- cls = cls.base
- return False
-
- def dispatch(self, f, attrs = ""):
- cls = self
- while cls != None:
- if hasattr(f, cls.type):
- return getattr(f, cls.type)(self)
- else:
- cls = cls.base
-
- cls = self
- while cls != None:
- if attrs:
- sep = ", "
- if cls.base == None:
- sep += "or "
- else:
- sep = ""
- attrs += "%s'%s'" % (sep, cls.type)
- cls = cls.base
-
- raise AttributeError("'%s' object has no attribute %s" %
- (f.__class__.__name__, attrs))
+ def is_type(self, type):
+ cls = self
+ while cls != None:
+ if cls.type == type:
+ return True
+ cls = cls.base
+ return False
+
+ def dispatch(self, f, attrs=""):
Review comment:
eh, never mind, it _is_ consistent
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Apply autofixes to resolve some flake8 code formatting issues
> -------------------------------------------------------------
>
> Key: PROTON-2320
> URL: https://issues.apache.org/jira/browse/PROTON-2320
> Project: Qpid Proton
> Issue Type: Task
> Components: python-binding
> Affects Versions: proton-c-0.33.0
> Reporter: Jiri Daněk
> Assignee: Jiri Daněk
> Priority: Major
> Fix For: proton-c-0.34.0
>
>
> Python code in Proton does not follow PEP8. There are automated tools which
> can reformat the code to be more compliant (fix indentation, add spaces
> around operators, ...).
> {noformat}
> pip install autopep8
> for f in `find -name "*.py"`; do autopep8 --in-place $f; done
> {noformat}
> Autopep8 has several level of "aggressiveness". The least aggressive setting
> only changes whitespace. At a more aggressive setting, autopep8 will also
> rewrite some code constructs.
> My plan is to commit this in several stages. Avoid mixing manual changes and
> automatically generated changes in a single commit. Push the whitespace
> changes first and only then let autopep8 to be more creative; otherwise the
> rewrites get drowned in the huge initial diff.
> I don't want to add flake8 to CI jobs just yet; I want to wait a few days
> with that.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
