[
https://issues.apache.org/jira/browse/PROTON-2321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17265750#comment-17265750
]
ASF GitHub Bot commented on PROTON-2321:
----------------------------------------
jiridanek commented on a change in pull request #286:
URL: https://github.com/apache/qpid-proton/pull/286#discussion_r557915002
##########
File path: c/benchmarks/message-encoding.cpp
##########
@@ -0,0 +1,67 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ *
+ */
+#include <unistd.h>
+
+#include <stdint.h>
+#include <stdio.h>
+#include <stdlib.h>
+#include <string.h>
+
+#include "proton/connection_driver.h"
+#include "proton/engine.h"
+#include "proton/log.h"
+#include "proton/message.h"
+
+#include <benchmark/benchmark.h>
+#include <core/data.h>
+#include <proton/listener.h>
+#include <proton/netaddr.h>
+#include <proton/proactor.h>
+#include <proton/sasl.h>
+#include <wait.h>
+
+/** Initialize message, don't decode?
+ * Issues:
+ * PROTON-2229 pn_data_t initialization lead to low performance
+ */
+static void BM_Encode10MbMessage(benchmark::State &state) {
+ const size_t size = 10*1024*1024;
+ char * payload = static_cast<char *>(malloc(size));
+ pn_bytes_t bytes = pn_bytes(size, payload);
+
+ for (auto _ : state) {
+ pn_message_t *message = pn_message();
+ pn_data_t * body = pn_message_body(message);
+ for (size_t i = 0; i < state.range(0); i++) {
+ pn_data_put_binary(body, bytes);
+ }
+
+ pn_message_free(message);
+ }
+
+ free(payload);
+}
+
+BENCHMARK(BM_Encode10MbMessage)
+->Arg(1)
+->Arg(10)
+->ArgName("put_binary count")
Review comment:
The idea here is that framework runs test twice, first the arg is 1,
then it is 10. The arg is used as iteration count for the nested for-loop, so
how many times `pn_data_put_binary` gets called.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add benchmark for pn_data_t initialization (PROTON-2229)
> --------------------------------------------------------
>
> Key: PROTON-2321
> URL: https://issues.apache.org/jira/browse/PROTON-2321
> Project: Qpid Proton
> Issue Type: Test
> Components: proton-c
> Affects Versions: proton-c-0.33.0
> Reporter: Jiri Daněk
> Assignee: Jiri Daněk
> Priority: Major
> Fix For: proton-c-0.34.0
>
>
> {noformat}
> -----------------------------------------------------------------------------------
> Benchmark Time CPU
> Iterations
> -----------------------------------------------------------------------------------
> // size_t size = bytes->size + 0;
> BM_Encode10MbMessage/put_binary count:1 71.7 ms 70.4 ms
> 10
> BM_Encode10MbMessage/put_binary count:10 239 ms 205 ms
> 3
> // size_t size = bytes->size + 1;
> BM_Encode10MbMessage/put_binary count:1 1.25 ms 0.874 ms
> 744
> BM_Encode10MbMessage/put_binary count:10 1059 ms 1045 ms
> 1
> // size_t size = bytes->size + 2;
> BM_Encode10MbMessage/put_binary count:1 1.22 ms 0.916 ms
> 634
> BM_Encode10MbMessage/put_binary count:10 178 ms 135 ms
> 5
> // size_t size = pn_max(bytes->size+1, PNI_INTERN_MINSIZE);
> BM_Encode10MbMessage/put_binary count:1 0.941 ms 0.815 ms
> 783
> BM_Encode10MbMessage/put_binary count:10 1390 ms 1187 ms
> 1
> // size_t size = pn_max(bytes->size+2, PNI_INTERN_MINSIZE);
> BM_Encode10MbMessage/put_binary count:1 0.922 ms 0.811 ms
> 718
> BM_Encode10MbMessage/put_binary count:10 184 ms 144 ms
> 5
> {noformat}
> The above shows that + 1 improves things significantly, but there is a
> scenario where + 2 is even better.
> {code}
> static int pni_data_intern_node(pn_data_t *data, pni_node_t *node)
> {
> pn_bytes_t *bytes = pni_data_bytes(data, node);
> if (!bytes) return 0;
> if (data->buf == NULL) {
> // Heuristic to avoid growing small buffers too much
> // size + 1 to allow for zero termination
> size_t size = pn_max(bytes->size+1, PNI_INTERN_MINSIZE);
> ...
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
