jiridanek commented on a change in pull request #989:
URL: https://github.com/apache/qpid-dispatch/pull/989#discussion_r560376141



##########
File path: tools/qdstat.in
##########
@@ -44,18 +44,17 @@ from qpid_dispatch_internal.compat import UNICODE
 def get(obj, attr):
     return getattr(obj, attr, None)
 
-class BusManager(Node):
+class BusManager():

Review comment:
       I'm with Ken here. 
https://docs.python.org/2.7/glossary.html#term-new-style-class and 
https://docs.python.org/2.7/reference/datamodel.html#newstyle state that you 
have to inherit from _object_ to get a new-style class. That is true even in 
Python 2.7.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to