kgiusti commented on a change in pull request #976:
URL: https://github.com/apache/qpid-dispatch/pull/976#discussion_r562118399
##########
File path: tests/system_tests_edge_router.py
##########
@@ -2521,14 +2568,18 @@ def check_address(self):
self.num_attempts += 1
for result in outs.results:
if self.address in result[0]:
- found = True
- self.create_sndr()
- local_node.close()
- self.addr_timer.cancel()
- break
+ if self.subscriber_count == 0 or (result[6] + result[7] ==
self.subscriber_count):
Review comment:
Might it be safer to use the actual attribute names rather than
hardcoded offsets to access the results?
Example:
https://github.com/apache/qpid-dispatch/blob/master/tests/system_tests_one_router.py#L616
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
