[
https://issues.apache.org/jira/browse/DISPATCH-1850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17269540#comment-17269540
]
ASF GitHub Bot commented on DISPATCH-1850:
------------------------------------------
kgiusti commented on a change in pull request #976:
URL: https://github.com/apache/qpid-dispatch/pull/976#discussion_r562118399
##########
File path: tests/system_tests_edge_router.py
##########
@@ -2521,14 +2568,18 @@ def check_address(self):
self.num_attempts += 1
for result in outs.results:
if self.address in result[0]:
- found = True
- self.create_sndr()
- local_node.close()
- self.addr_timer.cancel()
- break
+ if self.subscriber_count == 0 or (result[6] + result[7] ==
self.subscriber_count):
Review comment:
Might it be safer to use the actual attribute names rather than
hardcoded offsets to access the results?
Example:
https://github.com/apache/qpid-dispatch/blob/master/tests/system_tests_one_router.py#L616
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> system_tests_edge_router fails on
> test_25_multicast_mobile_address_different_edges_same_interior
> -------------------------------------------------------------------------------------------------
>
> Key: DISPATCH-1850
> URL: https://issues.apache.org/jira/browse/DISPATCH-1850
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Tests
> Affects Versions: 1.14.0
> Environment: rhel 8
> Reporter: Ganesh Murthy
> Assignee: Ganesh Murthy
> Priority: Major
>
> {noformat}
> ======================================================================
> FAIL: test_25_multicast_mobile_address_different_edges_same_interior
> (system_tests_edge_router.RouterTest)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/opt/qpid-dispatch-src/tests/system_tests_edge_router.py", line 644,
> in test_25_multicast_mobile_address_different_edges_same_interior
> self.assertEqual(None, test.error)
> AssertionError: None != 'Timeout Expired - n_sent=200 n_rcvd1=145[38
> chars]t.25'======================================================================
> FAIL: test_26_multicast_mobile_address_edge_to_interior
> (system_tests_edge_router.RouterTest)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/opt/qpid-dispatch-src/tests/system_tests_edge_router.py", line 659,
> in test_26_multicast_mobile_address_edge_to_interior
> self.assertEqual(None, test.error)
> AssertionError: None != 'Timeout Expired - n_sent=200 n_rcvd1=200[38
> chars]t.26'----------------------------------------------------------------------
> Ran 89 tests in 319.516sFAILED (failures=2) {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
