[ 
https://issues.apache.org/jira/browse/PROTON-2307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272180#comment-17272180
 ] 

ASF GitHub Bot commented on PROTON-2307:
----------------------------------------

codecov-io commented on pull request #278:
URL: https://github.com/apache/qpid-proton/pull/278#issuecomment-767631234


   # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/278?src=pr&el=h1) 
Report
   > Merging 
[#278](https://codecov.io/gh/apache/qpid-proton/pull/278?src=pr&el=desc) 
(f5a911d) into 
[master](https://codecov.io/gh/apache/qpid-proton/commit/0ee9ad7ff490a4b6a548ed41bef9e5d79783ec3b?el=desc)
 (0ee9ad7) will **increase** coverage by `4.36%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/qpid-proton/pull/278/graphs/tree.svg?width=650&height=150&src=pr&token=UKKzV9XnFF)](https://codecov.io/gh/apache/qpid-proton/pull/278?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #278      +/-   ##
   ==========================================
   + Coverage   79.56%   83.93%   +4.36%     
   ==========================================
     Files         343       46     -297     
     Lines       43066     2341   -40725     
   ==========================================
   - Hits        34267     1965   -32302     
   + Misses       8799      376    -8423     
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/qpid-proton/pull/278?src=pr&el=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[ruby/lib/core/message.rb](https://codecov.io/gh/apache/qpid-proton/pull/278/diff?src=pr&el=tree#diff-cnVieS9saWIvY29yZS9tZXNzYWdlLnJi)
 | `57.05% <0.00%> (-31.77%)` | :arrow_down: |
   | 
[ruby/lib/util/error\_handler.rb](https://codecov.io/gh/apache/qpid-proton/pull/278/diff?src=pr&el=tree#diff-cnVieS9saWIvdXRpbC9lcnJvcl9oYW5kbGVyLnJi)
 | `59.37% <0.00%> (-28.13%)` | :arrow_down: |
   | 
[ruby/lib/core/uri.rb](https://codecov.io/gh/apache/qpid-proton/pull/278/diff?src=pr&el=tree#diff-cnVieS9saWIvY29yZS91cmkucmI=)
 | `74.07% <0.00%> (-25.93%)` | :arrow_down: |
   | 
[ruby/lib/codec/data.rb](https://codecov.io/gh/apache/qpid-proton/pull/278/diff?src=pr&el=tree#diff-cnVieS9saWIvY29kZWMvZGF0YS5yYg==)
 | `76.52% <0.00%> (-19.57%)` | :arrow_down: |
   | 
[ruby/lib/codec/mapping.rb](https://codecov.io/gh/apache/qpid-proton/pull/278/diff?src=pr&el=tree#diff-cnVieS9saWIvY29kZWMvbWFwcGluZy5yYg==)
 | `88.17% <0.00%> (-1.08%)` | :arrow_down: |
   | 
[python/proton/handlers.py](https://codecov.io/gh/apache/qpid-proton/pull/278/diff?src=pr&el=tree#diff-cHl0aG9uL3Byb3Rvbi9oYW5kbGVycy5weQ==)
 | | |
   | 
[c/src/core/log.c](https://codecov.io/gh/apache/qpid-proton/pull/278/diff?src=pr&el=tree#diff-Yy9zcmMvY29yZS9sb2cuYw==)
 | | |
   | 
[c/tests/ssl\_proactor\_test.cpp](https://codecov.io/gh/apache/qpid-proton/pull/278/diff?src=pr&el=tree#diff-Yy90ZXN0cy9zc2xfcHJvYWN0b3JfdGVzdC5jcHA=)
 | | |
   | 
[cpp/include/proton/byte\_array.hpp](https://codecov.io/gh/apache/qpid-proton/pull/278/diff?src=pr&el=tree#diff-Y3BwL2luY2x1ZGUvcHJvdG9uL2J5dGVfYXJyYXkuaHBw)
 | | |
   | 
[cpp/src/ssl.cpp](https://codecov.io/gh/apache/qpid-proton/pull/278/diff?src=pr&el=tree#diff-Y3BwL3NyYy9zc2wuY3Bw)
 | | |
   | ... and [288 
more](https://codecov.io/gh/apache/qpid-proton/pull/278/diff?src=pr&el=tree-more)
 | |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/qpid-proton/pull/278?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/qpid-proton/pull/278?src=pr&el=footer). 
Last update 
[0ee9ad7...55ad0e8](https://codecov.io/gh/apache/qpid-proton/pull/278?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Allow access to connection properties in cpp binding
> ----------------------------------------------------
>
>                 Key: PROTON-2307
>                 URL: https://issues.apache.org/jira/browse/PROTON-2307
>             Project: Qpid Proton
>          Issue Type: Improvement
>          Components: cpp-binding
>    Affects Versions: proton-c-0.33.0
>            Reporter: Pete Fawcett
>            Priority: Minor
>              Labels: enhancement
>
> I would like to be able to set the "custom" properties on a connection using 
> the C++ bindings.
> The initial reason for this is to allow a client program to set the 
> "qpid.client_process" property on a connection to a broker as this is useful 
> when identifying the connection on the QMF console.
> I have written code to enable this and hope to submit a pull request soon.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to