fgiorgetti commented on pull request #944:
URL: https://github.com/apache/qpid-dispatch/pull/944#issuecomment-768275130


   > Thanks for the changes!
   > 
   > Regarding my objections from before. Things would be much nicer if the 
Python tests produced xml reports and it was possible to monitor how many tests 
were run, how many skipped, and if all tests that were expected to run were 
indeed run. I intend to look into this.
   
   I agree. One thing I was playing with here that could be a simple/easy 
option for us, is to add an extra test dependency
   `unittest-xml-reporting` and then we can verify if it is available though 
cmake (trying to `import xmlruner`), and if
   so we can modify the way tests are executed from `run.py -m unittest` to 
`run.py -m xmlrunner` and it will generate
   JUnit xml files for all python tests. Locally this seems to work just fine. 
Do you (or someone else) think it might be a
   good idea to raise a DISPATCH Jira to track this?
   
   > Also, an end-to-end test could be accompanied by something like a 
[contract 
test](https://blog.thecodewhisperer.com/permalink/getting-started-with-contract-tests),
 [also here](https://pactflow.io/). Implementing anything like this is a lot of 
work, though. It is similar to the idea of test-peers...
   > 
   > I'd like to wait until 1.15.0 dispatch is out before merging this.
   
   This contract test is interesting and it resembles BDD testing iiuc. 
Considering we are probably going to
   see more e2e tests coming to qpid-dispatch, it might be really interesting 
to organize them accordingly and eventually
   using some different approach for documenting test expectations.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to