[
https://issues.apache.org/jira/browse/PROTON-2217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17278910#comment-17278910
]
ASF GitHub Bot commented on PROTON-2217:
----------------------------------------
jiridanek commented on a change in pull request #294:
URL: https://github.com/apache/qpid-proton/pull/294#discussion_r570320151
##########
File path: CMakeLists.txt
##########
@@ -32,7 +32,27 @@ include (CheckPythonModule)
find_package (OpenSSL)
find_package (Threads)
-find_package (PythonInterp REQUIRED)
+# FindPython was added in CMake 3.12, but there it always returned
+# newest Python on the entire PATH. We want to use the first one.
+if (CMAKE_VERSION VERSION_LESS "3.15.0")
+ find_package (PythonInterp REQUIRED)
+ # forward compatibility with FindPython
+ set(Python_EXECUTABLE "${PYTHON_EXECUTABLE}")
+ set(Python_LIBRARIES "${PYTHON_LIBRARIES}")
+ set(Python_INCLUDE_DIRS "${PYTHON_INCLUDE_PATH}")
+ set(Python_VERSION_STRING "${PYTHON_VERSION_STRING}")
+ # for completeness, these are not actually used now
+ set(Python_VERSION_MAJOR "${PYTHON_VERSION_MAJOR}")
+ set(Python_VERSION_MINOR "${PYTHON_VERSION_MINOR}")
+ set(Python_VERSION_PATCH "${PYTHON_VERSION_PATCH}")
+else ()
+ if (POLICY CMP0094) #
https://cmake.org/cmake/help/latest/policy/CMP0094.html
+ cmake_policy(SET CMP0094 NEW) # FindPython should return the first
matching Python on PATH
+ endif ()
+
+ find_package(Python REQUIRED COMPONENTS Interpreter
+ OPTIONAL_COMPONENTS Development)
+endif()
Review comment:
Aha, makes sense; I agree that's the correct way. At least while CMake <
3.15 needs to be supported....
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Python detection logic prefers python2 over python3 when both are installed
> ---------------------------------------------------------------------------
>
> Key: PROTON-2217
> URL: https://issues.apache.org/jira/browse/PROTON-2217
> Project: Qpid Proton
> Issue Type: Bug
> Components: build, proton-c, python-binding
> Affects Versions: proton-c-0.31.0
> Reporter: Jiri Daněk
> Assignee: Jiri Daněk
> Priority: Major
>
> I have the same experience that was reported elsewhere:
> bq. For me, the find_package(PythonInterp) call was always finding the older
> interpreter (2.7) even though everything pointed to the newer one (3.6).
> (from https://reviews.llvm.org/D64881)
> This behavior is unfortunate on Ubuntu 20.04 Focal, where both python2 and
> python3 are available, but pip for python2 is not packaged. Therefore it
> makes sense to build proton with python3; which would make sense anyways,
> since Python 2.7 is deprecated by the Python Software Foundation nowadays..
> Besides removing python2 as discussed on the linked page, there is currently
> nicer way to force python3 that worked for me, by setting
> {{-DPYTHON_EXECUTABLE=/usr/bin/python3}} CMake variable.
> Related dispatch issue, DISPATCH-187
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
