[
https://issues.apache.org/jira/browse/PROTON-2330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17282463#comment-17282463
]
ASF GitHub Bot commented on PROTON-2330:
----------------------------------------
pjfawcett commented on a change in pull request #293:
URL: https://github.com/apache/qpid-proton/pull/293#discussion_r573738559
##########
File path: cpp/src/link_test.cpp
##########
@@ -45,8 +55,107 @@ int test_link_name()
return 0;
}
+/*
+ * Want to test remote properties so need to run a container and make loopback
links.
+ * Basing these classes on those used in container_test.cpp but reducing the
checks on
+ * container logic as that is not the subject of these tests.
+ */
Review comment:
@astitcher are you happy with the updated tests?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Allow access to session and link properties in cpp binding
> -----------------------------------------------------------
>
> Key: PROTON-2330
> URL: https://issues.apache.org/jira/browse/PROTON-2330
> Project: Qpid Proton
> Issue Type: Improvement
> Components: cpp-binding
> Affects Versions: proton-c-0.33.0
> Reporter: Pete Fawcett
> Priority: Minor
>
> As per the work done in PROTON-2307 for connection properties, extend the
> same approach to allow the setting of custom properties on sessions and links.
> Also allow retrieval of such properties as set by remote end on sessions and
> links.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
