ChugR commented on pull request #295: URL: https://github.com/apache/qpid-proton/pull/295#issuecomment-777896880
Dear ihsinme, I'm very discouraged to hear your description of the statement you want forgiven in such terms and your apology for it. Please let me encourage you by saying that qpid-proton is a massive undertaking and that it it quite easy to misunderstand the purpose and intent of some specific lines of code. I personally on a routine basis attribute errors to qpid-proton when the error is in some other component, so I can say from experience that "misunderstanding proton" is "normal". You have just joined the club with me! When I first saw your issue I wondered if the logic in question could not have been replaced with TCP SEQ_CMP logic, which has survived the test of time as being correct in that problem space. But as usual I was busy and I never got back to replying over the last few days. I'm sorry about that. Please stay on and challenge the qpid-proton code base wherever you see room for improvement. I am proud to see someone digging as deeply into it as you have. Regards, Chuck (chug, ChugR) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
