jiridanek commented on a change in pull request #827:
URL: https://github.com/apache/qpid-dispatch/pull/827#discussion_r579800383
##########
File path: tests/system_test.py
##########
@@ -421,29 +437,71 @@ def attributes(e, level):
# top level list of tuples ('section-name', dict)
return "".join(["%s {\n%s}\n"%(n, attributes(p, 1)) for n, p in
self])
- def __init__(self, name=None, config=Config(), pyinclude=None, wait=True,
+ def __init__(self, name=None, config=Config(), pyinclude=None, wait=True,
wait_for_server_log=True,
Review comment:
There are now three ways of waiting for server readiness. Wait for open
port, wait for `/healtz` endpoint (if libwebsockets is enabled for compilation)
or wait for special log line. It feels kind of confusing, what is the
difference, when should I do what, and so on.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
