[ 
https://issues.apache.org/jira/browse/DISPATCH-1814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17288029#comment-17288029
 ] 

ASF GitHub Bot commented on DISPATCH-1814:
------------------------------------------

codecov-io edited a comment on pull request #1053:
URL: https://github.com/apache/qpid-dispatch/pull/1053#issuecomment-782871638


   # 
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1053?src=pr&el=h1) 
Report
   > Merging 
[#1053](https://codecov.io/gh/apache/qpid-dispatch/pull/1053?src=pr&el=desc) 
(cee8296) into 
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/844f995a580ca630afe951ea7c5071bb02bc33f6?el=desc)
 (844f995) will **increase** coverage by `0.02%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/qpid-dispatch/pull/1053/graphs/tree.svg?width=650&height=150&src=pr&token=rk2Cgd27pP)](https://codecov.io/gh/apache/qpid-dispatch/pull/1053?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1053      +/-   ##
   ==========================================
   + Coverage   82.48%   82.50%   +0.02%     
   ==========================================
     Files         111      111              
     Lines       27425    27425              
   ==========================================
   + Hits        22621    22627       +6     
   + Misses       4804     4798       -6     
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1053?src=pr&el=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1053/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
 | `92.02% <0.00%> (-0.22%)` | :arrow_down: |
   | 
[src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1053/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=)
 | `93.32% <0.00%> (-0.20%)` | :arrow_down: |
   | 
[src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1053/diff?src=pr&el=tree#diff-c3JjL21lc3NhZ2UuYw==)
 | `87.07% <0.00%> (-0.08%)` | :arrow_down: |
   | 
[src/server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1053/diff?src=pr&el=tree#diff-c3JjL3NlcnZlci5j)
 | `86.78% <0.00%> (+0.10%)` | :arrow_up: |
   | 
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1053/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
 | `94.23% <0.00%> (+0.20%)` | :arrow_up: |
   | 
[src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1053/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j)
 | `93.04% <0.00%> (+0.39%)` | :arrow_up: |
   | 
[...c/router\_core/modules/test\_hooks/core\_test\_hooks.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1053/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvdGVzdF9ob29rcy9jb3JlX3Rlc3RfaG9va3MuYw==)
 | `93.31% <0.00%> (+1.27%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1053?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1053?src=pr&el=footer).
 Last update 
[844f995...cee8296](https://codecov.io/gh/apache/qpid-dispatch/pull/1053?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Apply autofixes to resolve some flake8 code formatting issues
> -------------------------------------------------------------
>
>                 Key: DISPATCH-1814
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-1814
>             Project: Qpid Dispatch
>          Issue Type: Task
>    Affects Versions: 1.14.0
>            Reporter: Jiri Daněk
>            Assignee: Jiri Daněk
>            Priority: Trivial
>             Fix For: 1.16.0
>
>
> The general strategy for dealing with these in a scalable manner could be as 
> follows
> Identify warning we want to resolve, e.g. E701 multiple statements on a 
> single line.
> Remove E701 from flake8 ignore list in {{tests/tox.ini.in}}.
> Run the autofixer
> {code}
> pip install autopep8
> for f in `find -name "*.py"`; do autopep8 --in-place --select=E701 $f; done
> for f in `find tests -name "*.py.in"`; do autopep8 --in-place --select=E701 
> $f; done
> autopep8 --in-place --select=E701 tools/*.in
> {code}
> Wait about two minutes.
> Review the diffs produced.
> Submit a change request.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to