[
https://issues.apache.org/jira/browse/DISPATCH-1974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17294594#comment-17294594
]
ASF GitHub Bot commented on DISPATCH-1974:
------------------------------------------
ChugR commented on a change in pull request #1058:
URL: https://github.com/apache/qpid-dispatch/pull/1058#discussion_r586511406
##########
File path: python/qpid_dispatch_internal/display_name/display_name.py
##########
@@ -29,14 +29,10 @@
from __future__ import absolute_import
from __future__ import print_function
-
+import json
import traceback
-from traceback import format_exc
-from ..router.message import Message
-
-from ..dispatch import IoAdapter, LogAdapter, LOG_INFO, LOG_ERROR, LOG_TRACE,
LOG_STACK_LIMIT
-import json
+from qpid_dispatch_internal import dispatch
Review comment:
agreed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Fix and remove ignores in flake8 configuration
> ----------------------------------------------
>
> Key: DISPATCH-1974
> URL: https://issues.apache.org/jira/browse/DISPATCH-1974
> Project: Qpid Dispatch
> Issue Type: Improvement
> Affects Versions: 1.16.0
> Reporter: Jiri Daněk
> Priority: Major
>
> Fixes with autopep8 in DISPATCH-1814 resolved many flake8 warnings. There are
> still warnings left that require human consideration and fixing.
> For example, usage of bare {{except}} in the code.
> This must be fixed manually. Fixed issues should then be removed from the
> tox.ini flake8 ignore section.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
