ChugR commented on a change in pull request #1058: URL: https://github.com/apache/qpid-dispatch/pull/1058#discussion_r586522506
########## File path: tests/system_tests_tcp_adaptor.py ########## @@ -61,7 +55,7 @@ class TCP_echo_server(object): DISABLE_SELECTOR_TESTS = False DISABLE_SELECTOR_REASON = '' try: - import selectors + import selectors # noqa F401: 'selectors' imported but unused Review comment: In order to run these tests the echo server and echo client must be run as subprocesses. And those programs use selectors. This test can't work without selectors even though it doesn't use them directly. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org