[ 
https://issues.apache.org/jira/browse/DISPATCH-2001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17302492#comment-17302492
 ] 

ASF GitHub Bot commented on DISPATCH-2001:
------------------------------------------

ganeshmurthy commented on a change in pull request #1074:
URL: https://github.com/apache/qpid-dispatch/pull/1074#discussion_r595145390



##########
File path: src/router_core/connections.c
##########
@@ -1443,6 +1443,7 @@ qdr_link_t 
*qdr_connection_new_streaming_link_CT(qdr_core_t *core, qdr_connectio
 
     if (out_link) {
         out_link->streaming = true;
+        out_link->priority = 4;

Review comment:
       Should we instead default the priority field in the qdr_link to 4  ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


> streaming messages incorrectly use priority 0 inter-router links
> ----------------------------------------------------------------
>
>                 Key: DISPATCH-2001
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-2001
>             Project: Qpid Dispatch
>          Issue Type: Bug
>          Components: Router Node
>    Affects Versions: 1.15.0
>            Reporter: Ken Giusti
>            Assignee: Ken Giusti
>            Priority: Major
>             Fix For: 1.16.0
>
>         Attachments: I'm sorry, Dave..png
>
>
> Priority 0 inter-router links carry routing protocol messages.  Using the 
> same priority for streaming messages can delay routing updates.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to