[
https://issues.apache.org/jira/browse/PROTON-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308525#comment-17308525
]
ASF GitHub Bot commented on PROTON-1936:
----------------------------------------
jiridanek commented on a change in pull request #156:
URL: https://github.com/apache/qpid-proton/pull/156#discussion_r601252880
##########
File path: c/src/platform/platform.h
##########
@@ -81,7 +81,7 @@ int pni_vsnprintf(char *buf, size_t count, const char *fmt,
va_list ap);
#endif
-#if defined _MSC_VER || defined _OPENVMS
+#if defined _MSC_VER || defined(_WIN32) || defined _OPENVMS
Review comment:
Note to myself: The switch I mentioned in previous comment already
happened, so va_copy on Windows can be relied on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Support cross compiling to Windows from Linux
> ---------------------------------------------
>
> Key: PROTON-1936
> URL: https://issues.apache.org/jira/browse/PROTON-1936
> Project: Qpid Proton
> Issue Type: Improvement
> Components: proton-c
> Affects Versions: proton-c-0.25.0
> Reporter: Marcel Meulemans
> Priority: Minor
>
> I am cross compiling proton for Windows via docker (multiarch/crossbuild) and
> running into a few minor issues that make it not work out of the box (mainly
> include file casing). Pull request will follow, more details there ... it
> would be nice if this made it upstream.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
