[
https://issues.apache.org/jira/browse/QPIDJMS-530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17311376#comment-17311376
]
David Martin commented on QPIDJMS-530:
--------------------------------------
I pulled the commit referenced above and ran mvn test. A single test reported a
failure:
{noformat}
[INFO] Running org.apache.qpid.jms.provider.failover.FailoverIntegrationTest
[ERROR] Tests run: 81, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 24.794
s <<< FAILURE! - in
org.apache.qpid.jms.provider.failover.FailoverIntegrationTest
[ERROR]
testTxCommitThrowsWhenNoDischargeResponseSentAndConnectionDrops(org.apache.qpid.jms.provider.failover.FailoverIntegrationTest)
Time elapsed: 5.156 s <<< FAILURE!
java.lang.AssertionError: Should reported failed
at
org.apache.qpid.jms.provider.failover.FailoverIntegrationTest.testTxCommitThrowsWhenNoDischargeResponseSentAndConnectionDrops(FailoverIntegrationTest.java:2599)
{noformat}
It could be because I'm running Windows? I haven't had time to look into it but
I will have a closer look later.
> Potential NPE in JmsSession consumerClosed()
> --------------------------------------------
>
> Key: QPIDJMS-530
> URL: https://issues.apache.org/jira/browse/QPIDJMS-530
> Project: Qpid JMS
> Issue Type: Bug
> Affects Versions: 0.56.0
> Reporter: David Martin
> Assignee: Timothy A. Bish
> Priority: Major
> Fix For: 0.58.0
>
>
> In the following code (JMSSession line 416), if consumer is null this throws
> a NPE and the consumer never recovers:
> {noformat}
> JmsMessageConsumer consumer = consumers.get(resource.getId());
> if (consumer.hasMessageListener()) {
> connection.onAsyncException(JmsExceptionSupport.create(cause));
> }
> try {
> if (consumer != null) {
> consumer.shutdown(cause);
> }
> {noformat}
> Happy to raise a PR myself for this (just ask) but I have had to fix it
> locally.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
