DreamPearl commented on pull request #303: URL: https://github.com/apache/qpid-proton/pull/303#issuecomment-812563434
> Thanks, Rakhi. This looks good. I agree about the "empty" side. I think we should either drop that logic from url.cpp or change it to an assertion. > > I added a few small points on a per-line basis. I'll also ask one of the C++ contributors on the team to take a look. Thanks, Justin @ssorj. Updated the url.cpp. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
