[
https://issues.apache.org/jira/browse/DISPATCH-1933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17314490#comment-17314490
]
ASF GitHub Bot commented on DISPATCH-1933:
------------------------------------------
jiridanek commented on pull request #1102:
URL: https://github.com/apache/qpid-dispatch/pull/1102#issuecomment-813030070
Going over this again, it looks to me that all the necessary pieces are
there. Just few small details missing, around it.
## TODO
* get rid of this silly warning
```
34: =============================== warnings summary
===============================
34: ../../tests/system_test.py:1310
34: /foo/qpid-dispatch/tests/system_test.py:1310: PytestCollectionWarning:
cannot collect test class 'TestTimeout' because it has a __init__ constructor
(from: )
34: class TestTimeout(object):
34:
34: -- Docs: https://docs.pytest.org/en/stable/warnings.html
34: - generated xml file:
/foo/qpid-dispatch/build/tests/junitxmls/system_tests_two_routers.xml -
34: =================== 32 passed, 1 warning in 64.90s (0:01:04)
===================
```
* figure out how best to install pytest on RHEL 7
* decide on precise pytest command we want, it should probably include
`--junit-prefix=`
* use this in ASF Jenkins?
* does it still work without `tox`? (see related cmake magic)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Tests should produce JUnit-compatible XML report about individual tests (not
> aggregated CTest test targets)
> -----------------------------------------------------------------------------------------------------------
>
> Key: DISPATCH-1933
> URL: https://issues.apache.org/jira/browse/DISPATCH-1933
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Tests
> Affects Versions: 1.14.0
> Reporter: Jiri Daněk
> Priority: Major
> Fix For: 1.16.0
>
>
> We can use either {{unittest-xml-reporting}} or {{pytest}} as a dependency to
> run the system-tests and obtain such XML report.
> We can modify the way tests are executed from {{run.py python -m unittest}}
> to {{run.py python -m xmlrunner}} (or {{python -m pytest
> --junitxml=path-to.xml}}) and it will generate the report. Each system-test
> must produce differently-named report, to avoid overwriting.
> I prefer pytest for this (it is compatible with unittest tests), but I don't
> mind using xmlrunner if there are any obvious advantages (like not having to
> configure path to destination file?
> * https://pypi.org/project/unittest-xml-reporting/
> * https://docs.pytest.org/en/stable/usage.html#creating-junitxml-format-files
> CC [~fgiorget], thanks for describing how to do this with {{xmlrunner}}.
> https://github.com/apache/qpid-dispatch/pull/944#issuecomment-768275130
> For unittests, the doctest framework can produce xml output. The bespoke test
> macros used in the remainder of unittests cannot. These tests can be migrated
> to doctest, or maybe simply ignored for now, because they always run anyways,
> AFAIK there is no skipping.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
