[ https://issues.apache.org/jira/browse/DISPATCH-836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315095#comment-17315095 ]
ASF subversion and git services commented on DISPATCH-836: ---------------------------------------------------------- Commit f2589bb3577de4b02693ac3f32022504d92562fc in qpid-dispatch's branch refs/heads/main from Jiri Daněk [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=f2589bb ] DISPATCH-836 Standardize #include order (#1105) > Source file organization suffers from include hell > -------------------------------------------------- > > Key: DISPATCH-836 > URL: https://issues.apache.org/jira/browse/DISPATCH-836 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Container, Router Node, Routing Engine > Affects Versions: 0.8.0 > Reporter: Charles E. Rolke > Assignee: Jiri Daněk > Priority: Minor > Fix For: 1.16.0 > > > Adding an innocent looking #include to some module may unleash a barrage of > errors instead of simply defining the header's interface. Reordering and/or > adding more #include statements is required to get it right. > A good way to address this is to make certain that each module.h file > compiles cleanly on its own. It is tedious and pretty unrewarding to check > each file. One strategy to address this problem is for each module to > _#include module.h_ as the first include\[1\]. Then every compile checks that > the module.h files compiles cleanly. This strategy is recommended by > astitcher and used by qpid-cpp with great results. > \[1\] One exception to this rule is including the #include Python.h ahead of > all others. This is a requirement. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org