[
https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17320531#comment-17320531
]
ASF GitHub Bot commented on PROTON-2370:
----------------------------------------
jiridanek commented on a change in pull request #309:
URL: https://github.com/apache/qpid-proton/pull/309#discussion_r612765958
##########
File path: cpp/src/delivery.cpp
##########
@@ -40,6 +42,7 @@ namespace proton {
delivery::delivery(pn_delivery_t* d): transfer(make_wrapper(d)) {}
receiver delivery::receiver() const { return make_wrapper<class
receiver>(pn_delivery_link(pn_object())); }
+tag delivery::tag() const { return make_wrapper<class
tag>(pn_delivery_tag(pn_object())); }
Review comment:
@ssorj For your example, is is necessary to set custom delivery tags
when sending messages, or is it ok to have the tags generated by the binding,
and then make them available read-only? Do you need to be absolutely sure that
delivery tags are unique?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [cpp] An accessor for the delivery tag
> --------------------------------------
>
> Key: PROTON-2370
> URL: https://issues.apache.org/jira/browse/PROTON-2370
> Project: Qpid Proton
> Issue Type: Improvement
> Components: cpp-binding
> Reporter: Justin Ross
> Priority: Major
>
> *Assignee: Rakhi*
> Steps:
> * Get familiar with the AMQP idea of a delivery tag
> * Add a delivery tag accessor to the C++ delivery class
> * Document the accessor in the C++ header
> * Add a test for the accessor to the C++ test suite
> Resources:
> *
> [http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-transport-v1.0-os.html#doc-idp438000]
> *
> [http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-transport-v1.0-os.html#type-delivery-tag]
> *
> [https://github.com/apache/qpid-proton/blob/main/c/include/proton/delivery.h#L106]
> *
> [https://github.com/apache/qpid-proton/blob/main/cpp/include/proton/delivery.hpp]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
