[ 
https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17323789#comment-17323789
 ] 

ASF GitHub Bot commented on PROTON-2370:
----------------------------------------

DreamPearl edited a comment on pull request #309:
URL: https://github.com/apache/qpid-proton/pull/309#issuecomment-821153641


   > My guess: you created a new file tag.hpp and forgot to commit it?
   
   I once created this file but later deleted it, then forgot to delete it from 
include :'(    Fixed now.
   
   > @DreamPearl It's probably a high time you fixed the CI failure 
https://github.com/apache/qpid-proton/pull/309/checks?check_run_id=2362084471#step:11:185
   
   I am still working on fixing tests.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [cpp] An accessor for the delivery tag
> --------------------------------------
>
>                 Key: PROTON-2370
>                 URL: https://issues.apache.org/jira/browse/PROTON-2370
>             Project: Qpid Proton
>          Issue Type: Improvement
>          Components: cpp-binding
>            Reporter: Justin Ross
>            Assignee: Rakhi Kumari
>            Priority: Major
>
> *Assignee: Rakhi*
> Steps:
>  * Get familiar with the AMQP idea of a delivery tag
>  * Add a delivery tag accessor to the C++ delivery class
>  * Document the accessor in the C++ header
>  * Add a test for the accessor to the C++ test suite
> Resources:
>  * 
> [http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-transport-v1.0-os.html#doc-idp438000]
>  * 
> [http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-transport-v1.0-os.html#type-delivery-tag]
>  * 
> [https://github.com/apache/qpid-proton/blob/main/c/include/proton/delivery.h#L106]
>  * 
> [https://github.com/apache/qpid-proton/blob/main/cpp/include/proton/delivery.hpp]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to