jiridanek commented on a change in pull request #309: URL: https://github.com/apache/qpid-proton/pull/309#discussion_r615817623
########## File path: cpp/src/delivery_test.cpp ########## @@ -0,0 +1,139 @@ +/* + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + * + */ + +#include <proton/connection.hpp> +#include <proton/connection_options.hpp> +#include <proton/container.hpp> +#include <proton/delivery.h> +#include <proton/delivery.hpp> +#include <proton/link.hpp> +#include <proton/listen_handler.hpp> +#include <proton/listener.hpp> +#include <proton/message.hpp> +#include <proton/message_id.hpp> +#include <proton/messaging_handler.hpp> +#include <proton/tracker.hpp> +#include <proton/types.h> +#include <proton/types.hpp> +#include <proton/value.hpp> + +#include "proton/error_condition.hpp" +#include "proton/internal/pn_unique_ptr.hpp" +#include "proton/receiver_options.hpp" +#include "proton/transport.hpp" +#include "proton/work_queue.hpp" +#include "test_bits.hpp" + +#include <condition_variable> +#include <mutex> +#include <thread> + +namespace { +std::mutex m; +std::condition_variable cv; +bool listener_ready = false; +int listener_port; +} // namespace + +class test_recv : public proton::messaging_handler { + private: + class listener_ready_handler : public proton::listen_handler { + void on_open(proton::listener &l) PN_CPP_OVERRIDE { + std::unique_lock<std::mutex> lk(m); + std::cout << "listening on " << l.port() << std::endl; Review comment: few things: * remove the "listening on" print, tests should be silent when they are running ok * pull all code that does not have to be guarded by the lock outside of the locked section (that's the print, which you'll delete, so nothing to do here) * consider using {} and RAII for the lock, so that you don't have to explicitly call unlock ``` { std::lock_guard<std::mutex> lk(cv_m); listener_port = l.port();  listener_ready = true; } ``` the lock will unlock itself after the {} block. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
