ganeshmurthy commented on a change in pull request #1176:
URL: https://github.com/apache/qpid-dispatch/pull/1176#discussion_r623091408
##########
File path: src/connection_manager.c
##########
@@ -859,16 +861,23 @@ qd_error_t qd_entity_refresh_connector(qd_entity_t*
entity, void *impl)
case CXTR_STATE_INIT:
state_info = "INITIALIZING";
break;
+ case CXTR_STATE_DELETED:
+ state_info = "DELETED";
+ break;
default:
state_info = "UNKNOWN";
break;
}
if (qd_entity_set_string(entity, "failoverUrls", failover_info) == 0
- && qd_entity_set_string(entity, "connectionStatus", state_info) == 0
- && qd_entity_set_string(entity, "connectionMsg", ct->conn_msg) ==
0)
+ && qd_entity_set_string(entity, "connectionStatus", state_info) == 0
+ && qd_entity_set_string(entity, "connectionMsg", ct->conn_msg) == 0) {
+
+ sys_mutex_unlock(ct->lock);
Review comment:
can we change this to connector->lock ? In some places we have ct->lock
and in some places we have connector->lock. The connector->lock is easier to
understand IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
