[ 
https://issues.apache.org/jira/browse/PROTON-2380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17340462#comment-17340462
 ] 

ASF subversion and git services commented on PROTON-2380:
---------------------------------------------------------

Commit d9e0deec6cdc54f3f41f5698abfba3b74e08c9c4 in qpid-protonj2's branch 
refs/heads/main from Timothy Bish
[ https://gitbox.apache.org/repos/asf?p=qpid-protonj2.git;h=d9e0dee ]

PROTON-2380 Improve output of frame traces for various AMQP types

Improves the logging output for several of the AMQP types by reporting
the actual state of the fields when logged (null if not set) and
stringifying the buffer payloads of several types.

> frame tracing issues/improvements
> ---------------------------------
>
>                 Key: PROTON-2380
>                 URL: https://issues.apache.org/jira/browse/PROTON-2380
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: protonj2
>    Affects Versions: protonj2-1.0.0-M1
>            Reporter: Robbie Gemmell
>            Assignee: Timothy A. Bish
>            Priority: Major
>
> Running the HelloWorld example against Broker-J 8.0.4 with PN_TRACE_FRM=true 
> style frame trace enabled shows some areas for improvement.
> * Nothing distinguishes the connection it applies to (e.g in other cases we 
> log include the memory address), limiting value in multi-connection use 
> cases. 
> * The run ultimately resulted in exposing a broker bug (QPID-8523), causing 
> connection closure with explanation, but the attach frame trace itself didnt 
> show the issue at all, instead implying a value was sent (printing 
> initialDeliveryCount=0). Some way of distinguishing actual vs default (in 
> code terms) values received, and possibly how many fields were populated, 
> would be useful. 
> * Some binary bits will just print out the buffer class/sizes etc.
> * The initial SASL header is prefixed 'AMQP' which is debatable (both ways, 
> since its only a header). May be simpler to say SASL to show transition. Or 
> drop the prefix.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to