jiridanek commented on a change in pull request #312: URL: https://github.com/apache/qpid-proton/pull/312#discussion_r639686204
########## File path: c/CMakeLists.txt ########## @@ -487,16 +492,18 @@ if (BUILD_STATIC_LIBS) target_compile_definitions(qpid-proton-static PUBLIC PROTON_DECLARE_STATIC) target_link_libraries (qpid-proton-static qpid-proton-core-static - $<$<BOOL:${HAS_PROACTOR}>:qpid-proton-proactor-static> + ${TARTET_qpid-proton-proactor-static} Review comment: I have to do it this way. I have to evaluate everything in the context of the Proton project and then see the result in Dispatch (or whatever dependent project). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org