[
https://issues.apache.org/jira/browse/DISPATCH-2136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351860#comment-17351860
]
ASF GitHub Bot commented on DISPATCH-2136:
------------------------------------------
codecov-commenter commented on pull request #1235:
URL: https://github.com/apache/qpid-dispatch/pull/1235#issuecomment-848860237
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1235?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#1235](https://codecov.io/gh/apache/qpid-dispatch/pull/1235?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(c8b7813) into
[main](https://codecov.io/gh/apache/qpid-dispatch/commit/6c6cdd10cbf3b4d020a288df4d74614e4768f610?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(6c6cdd1) will **decrease** coverage by `0.06%`.
> The diff coverage is `84.61%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/1235?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## main #1235 +/- ##
==========================================
- Coverage 84.71% 84.65% -0.07%
==========================================
Files 113 113
Lines 28006 28012 +6
==========================================
- Hits 23726 23714 -12
- Misses 4280 4298 +18
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1235?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[src/adaptors/http1/http1\_server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1235/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX3NlcnZlci5j)
| `84.57% <0.00%> (ø)` | |
|
[src/router\_core/delivery.h](https://codecov.io/gh/apache/qpid-dispatch/pull/1235/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5Lmg=)
| `100.00% <ø> (ø)` | |
|
[src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1235/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
| `90.54% <66.66%> (ø)` | |
|
[src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1235/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21lc3NhZ2UuYw==)
| `87.23% <100.00%> (-0.11%)` | :arrow_down: |
|
[src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1235/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=)
| `93.33% <100.00%> (+0.18%)` | :arrow_up: |
|
[src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1235/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2l0ZXJhdG9yLmM=)
| `89.29% <0.00%> (-4.05%)` | :arrow_down: |
|
[src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1235/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j)
| `92.64% <0.00%> (-0.40%)` | :arrow_down: |
|
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1235/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
| `93.57% <0.00%> (-0.20%)` | :arrow_down: |
| ... and [2
more](https://codecov.io/gh/apache/qpid-dispatch/pull/1235/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1235?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1235?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[87282a6...c8b7813](https://codecov.io/gh/apache/qpid-dispatch/pull/1235?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> race accessing the aborted message flag
> ---------------------------------------
>
> Key: DISPATCH-2136
> URL: https://issues.apache.org/jira/browse/DISPATCH-2136
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Router Node
> Affects Versions: 1.16.0
> Reporter: Ken Giusti
> Assignee: Charles E. Rolke
> Priority: Major
> Labels: race-condition, tsan
> Fix For: 1.17.0
>
>
> Asynchronous read/write of the aborted flag in the message content:
>
> 45: WARNING: ThreadSanitizer: data race (pid=652672)
> 45: Write of size 1 at 0x7b64000928b4 by thread T1 (mutexes: write M374):
> 45: #0 qd_message_set_aborted
> /home/kgiusti/work/dispatch/qpid-dispatch/src/message.c:2911
> (libqpid-dispatch.so+0x9a4e4)
> 45: #1 qdr_delivery_set_aborted
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/delivery.c:123
> (libqpid-dispatch.so+0xd6453)
> 45: #2 qdr_link_abort_undelivered_CT
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/connections.c:980
> (libqpid-dispatch.so+0xc7fa1)
> 45: #3 qdr_link_inbound_detach_CT
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/connections.c:2008
> (libqpid-dispatch.so+0xce691)
> 45: #4 router_core_thread
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/router_core_thread.c:239
> (libqpid-dispatch.so+0xfb305)
> 45: #5 _thread_init
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:172
> (libqpid-dispatch.so+0xad38a)
> 45: #6 <null> <null> (libtsan.so.0+0x2d33f)
> 45:
> 45: Previous read of size 1 at 0x7b64000928b4 by thread T3:
> 45: #0 qd_message_send
> /home/kgiusti/work/dispatch/qpid-dispatch/src/message.c:1885
> (libqpid-dispatch.so+0x95b6d)
> 45: #1 CORE_link_deliver
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_node.c:1985
> (libqpid-dispatch.so+0x127ff6)
> 45: #2 qdr_link_process_deliveries
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/transfer.c:178
> (libqpid-dispatch.so+0x10461d)
> 45: #3 CORE_link_push
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_node.c:1920
> (libqpid-dispatch.so+0x127d57)
> 45: #4 qdr_connection_process
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/connections.c:414
> (libqpid-dispatch.so+0xc4bfc)
> 45: #5 AMQP_writable_conn_handler
> /home/kgiusti/work/dispatch/qpid-dispatch/src/router_node.c:299
> (libqpid-dispatch.so+0x122d99)
> 45: #6 writable_handler
> /home/kgiusti/work/dispatch/qpid-dispatch/src/container.c:395
> (libqpid-dispatch.so+0x7b2f2)
> 45: #7 qd_container_handle_event
> /home/kgiusti/work/dispatch/qpid-dispatch/src/container.c:747
> (libqpid-dispatch.so+0x7cfe5)
> 45: #8 handle /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1096
> (libqpid-dispatch.so+0x13058e)
> 45: #9 thread_run /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1121
> (libqpid-dispatch.so+0x130691)
> 45: #10 _thread_init
> /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:172
> (libqpid-dispatch.so+0xad38a)
> 45: #11 <null> <null> (libtsan.so.0+0x2d33f)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
