ganeshmurthy commented on a change in pull request #1235: URL: https://github.com/apache/qpid-dispatch/pull/1235#discussion_r639909306
########## File path: src/message.c ########## @@ -45,6 +45,10 @@ #define LOCK sys_mutex_lock #define UNLOCK sys_mutex_unlock +// Implement bool flags with atomic variables +#define SET_FLAG(flag) sys_atomic_set(flag, 1) +#define IS_FLAG(flag) (sys_atomic_get(flag) == 1) Review comment: IMO, I think the #define IS_FLAG(flag) can be called #define IS_FLAG_SET(flag) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org