alex-rufous commented on a change in pull request #76:
URL: https://github.com/apache/qpid-broker-j/pull/76#discussion_r606824002
##########
File path:
broker-core/src/main/java/org/apache/qpid/server/model/NamedAddressSpace.java
##########
@@ -48,8 +49,13 @@
boolean registerConnection(AMQPConnection<?> connection,
final ConnectionEstablishmentPolicy
connectionEstablishmentPolicy);
+
void deregisterConnection(AMQPConnection<?> connection);
+ default ConnectionSlot requestConnectionSlot(AMQPConnection<?> connection)
Review comment:
Let rename this method into checkConnectionLimits
void checkConnectionLimits(AMQPConnection<?> connection)
As per previous comments I do not see a need to return a ConnectionSlot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
