[
https://issues.apache.org/jira/browse/DISPATCH-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363168#comment-17363168
]
ASF GitHub Bot commented on DISPATCH-1977:
------------------------------------------
kgiusti commented on a change in pull request #1253:
URL: https://github.com/apache/qpid-dispatch/pull/1253#discussion_r651216579
##########
File path: src/adaptors/http2/http2_adaptor.c
##########
@@ -2426,6 +2436,8 @@ static void handle_connection_event(pn_event_t *e,
qd_server_t *qd_server, void
send_settings_frame(conn);
qd_log(log, QD_LOG_INFO, "[C%"PRIu64"] Accepted Ingress
((PN_RAW_CONNECTION_CONNECTED)) from %s", conn->conn_id, conn->remote_address);
} else {
+ sys_atomic_init(&conn->raw_closed_read, 0);
Review comment:
Why re-init? Won't this destroy the existing state?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [http2] adaptor must not call proton functions after pn_raw_connection_close
> ----------------------------------------------------------------------------
>
> Key: DISPATCH-1977
> URL: https://issues.apache.org/jira/browse/DISPATCH-1977
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Protocol Adaptors
> Affects Versions: 1.15.0
> Reporter: Charles E. Rolke
> Assignee: Ganesh Murthy
> Priority: Major
> Fix For: 1.17.0
>
>
> Http2 adaptor code may have the same problem as DISPATCH-1968 TCP adaptor
> code.
> The rule is never to call pn_raw_connection_wake or
> pn_raw_connection_write_buffers after calling pn_raw_connection_close.
> The trigger for the failure, at least in the tcp adaptor case, is to close
> the server-side connection while the client-side connection is sending to it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
