[ 
https://issues.apache.org/jira/browse/DISPATCH-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17369568#comment-17369568
 ] 

ASF subversion and git services commented on DISPATCH-2184:
-----------------------------------------------------------

Commit e740dedbdd7c268757529d86b6f5f36030c6ebc7 in qpid-dispatch's branch 
refs/heads/main from Ken Giusti
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=e740ded ]

DISPATCH-2184: invoke Q2 unblock handler on Q2 disable

Rather than have the caller of qd_message_Q2_holdoff_disable() have to
call the unblock handler manually just have
qd_message_Q2_holdoff_disable() call it if necessary.

This avoids having to rely on the developer remembering that extra
step to call the unblock handler.

This closes #1273


> message receiver is not restarted by qd_message_Q2_holdoff_disable
> ------------------------------------------------------------------
>
>                 Key: DISPATCH-2184
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-2184
>             Project: Qpid Dispatch
>          Issue Type: Bug
>          Components: Router Node
>    Affects Versions: 1.16.0
>            Reporter: Ken Giusti
>            Assignee: Ken Giusti
>            Priority: Critical
>             Fix For: 1.16.0
>
>
> When a message needs to have its Q2 disabled - for discard or local consume - 
> the qd_message_Q2_holdoff_disable() function is called.   This function 
> simply sets a flag in the message indicating Q2 is disabled.
> However, if Q2 is effect when qd_message_Q2_holdoff_disable() is called the 
> message's incoming thread is not activated.  This may cause the receipt of 
> the message to stall indefinitely.
> The qd_message_Q2_holdoff_disable() call must re-start the message's receiver 
> thread if Q2 is in effect when called.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to