[
https://issues.apache.org/jira/browse/QPIDJMS-542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17370631#comment-17370631
]
ASF GitHub Bot commented on QPIDJMS-542:
----------------------------------------
gemmellr commented on pull request #41:
URL: https://github.com/apache/qpid-jms/pull/41#issuecomment-869743728
I have pushed an alternative commit
https://github.com/apache/qpid-jms/commit/531a48eb4edfb609df6a054d999296e6b65ce53f
that implements the functionality in a slightly different way. It keeps the
context factory changes a bit simpler and I also ensured the new config route
supports the same variable expansion the regular existing connection factory
config route does.
They will behave the same for the usage the JIRA suggests and your test
covered, and I used your test as a basis for the ones added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Support configuring default ConnectionFactory via the naming provider url
> property
> ----------------------------------------------------------------------------------
>
> Key: QPIDJMS-542
> URL: https://issues.apache.org/jira/browse/QPIDJMS-542
> Project: Qpid JMS
> Issue Type: Improvement
> Components: qpid-jms-client
> Affects Versions: 1.0.0
> Reporter: Michael Andre Pearce
> Assignee: Robbie Gemmell
> Priority: Major
> Fix For: 1.1.0
>
>
> Both in ActiveMQ OpenWire and ActiveMQ Artemis Core clients with their
> respective JMS InitialContextFactory implementations it is possible to set
> the connection url as the naming provider url property directly, creating
> default connection factories with that connection url.
> This is very convenient as well some third party systems annoyingly have also
> been built around that, making transition to Qpid JMS client from older
> ActiveMQ Openwire or Artemis trickey and problematic where we want to migrate
> fully to AMQP protocol with the brokers from all systems.
> e.g.
> ActiveMQ 5.x Openwire:
> {code:java}
> java.naming.factory.initial=org.apache.activemq.jndi.ActiveMQInitialContextFactory
> java.naming.provider.url=tcp://hostname:61616
> {code}
> ActiveMQ Artemis Core
> {code:java}
> java.naming.factory.initial=org.apache.activemq.artemis.jndi.ActiveMQInitialContextFactory
> java.naming.provider.url=tcp://localhost:5445
> {code}
>
> Intent is to support the same, for qpid-jms.
> e.g.
> {code:java}
> java.naming.factory.initial=org.apache.qpid.jms.jndi.JmsInitialContextFactory
> java.naming.provider.url=amqps://localhost:5672
> {code}
> or
> {code:java}
> java.naming.factory.initial=org.apache.qpid.jms.jndi.JmsInitialContextFactory
> java.naming.provider.url=failover:(amqps://host1:5672,amqps://host2:5672)
> {code}
> Followed by e.g. lookup of the "ConnectionFactory" default factory created on
> the Context:
> {code:java}
> ConnectionFactory connectionFactory = (ConnectionFactory)
> context.lookup("ConnectionFactory");
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
