[ 
https://issues.apache.org/jira/browse/DISPATCH-2189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17373117#comment-17373117
 ] 

ASF GitHub Bot commented on DISPATCH-2189:
------------------------------------------

ganeshmurthy commented on a change in pull request #1281:
URL: https://github.com/apache/qpid-dispatch/pull/1281#discussion_r662667112



##########
File path: tests/http1_tests.py
##########
@@ -1353,3 +1356,189 @@ def client_response_close_test(self, server_port, 
client_port):
         client = ThreadedTestClient(PING, client_port)
         client.wait()
         server.wait()
+
+
+class Http1CurlTestsMixIn(object):
+    """
+    Test cases using curl as the command line client
+    """
+
+    def _run_curl(self, args, input=None, timeout=TIMEOUT):

Review comment:
       Can we put this run_curl in say system_test.py so the http2 can use it 
as well. Otherwise this will go the way of run_qdstat, there are so many of 
those all over the place, most of them doing the same thing.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> HTTP/1.x hangs if client sends "Expect: 100-continue" header
> ------------------------------------------------------------
>
>                 Key: DISPATCH-2189
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-2189
>             Project: Qpid Dispatch
>          Issue Type: Bug
>          Components: Protocol Adaptors
>    Affects Versions: 1.16.0
>            Reporter: Ken Giusti
>            Assignee: Ken Giusti
>            Priority: Major
>
> The "curl" tool will include an "Expect: 100-continue" header in PUT/POST 
> operations.  curl will then block until the server has responded with a "100 
> Continue".   See 
> [rfc723|https://datatracker.ietf.org/doc/html/rfc7231#section-5.1.1].
> In order to minimize message fragmentation at the TCP/IP layer the router 
> will not immediately forward a small message that is streaming (See 
> DISPATCH-1545). However, the curl client's message is too small to trigger 
> the streaming logic and will never signal receive-complete as it is waiting 
> for a response from the server.  This means the partial request message is 
> never forwarded and curl hangs.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to