Dedeepya-T commented on a change in pull request #99:
URL: https://github.com/apache/qpid-broker-j/pull/99#discussion_r665984594



##########
File path: 
bdbstore/src/main/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacade.java
##########
@@ -346,19 +342,36 @@ public void commit(final Transaction tx, boolean 
syncCommit)
 
     }
 
-    @Override
-    public <X> ListenableFuture<X> commitAsync(final Transaction tx, final X 
val)
+    public void commitInternal(final Transaction tx, final Durability 
realMessageStoreDurability)

Review comment:
       For Unit tests i made it public.. however the unit testing seems less 
practical here. So making it private




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to