ganeshmurthy commented on a change in pull request #1308:
URL: https://github.com/apache/qpid-dispatch/pull/1308#discussion_r674028923
##########
File path: src/message.c
##########
@@ -1225,7 +1241,7 @@ int qd_message_get_phase_annotation(const qd_message_t
*in_msg)
void qd_message_set_stream_annotation(qd_message_t *in_msg, bool stream)
{
qd_message_pvt_t *msg = (qd_message_pvt_t*) in_msg;
- msg->content->ma_stream = stream;
+ sys_atomic_set(&msg->content->ma_stream, (stream ? 1 : 0));
Review comment:
just a thought. Instead of calling sys_atomic_set can we do the
following -
if (stream) {
SET_ATOMIC_FLAG(&msg->content->ma_stream)
}
else {
CLEAR_ATOMIC_FLAG(&msg->content->ma_stream)
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
