[ 
https://issues.apache.org/jira/browse/DISPATCH-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17386280#comment-17386280
 ] 

ASF GitHub Bot commented on DISPATCH-1595:
------------------------------------------

ChugR commented on pull request #1197:
URL: https://github.com/apache/qpid-dispatch/pull/1197#issuecomment-885695863


   The handling in system_test makes a nice on_modified callback for dispatch 
self tests. Leave it as-is.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


> Python tests define on_modified handler when proton has none
> ------------------------------------------------------------
>
>                 Key: DISPATCH-1595
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-1595
>             Project: Qpid Dispatch
>          Issue Type: Bug
>          Components: Tests
>    Affects Versions: 1.10.0
>            Reporter: Charles E. Rolke
>            Priority: Major
>
> Proton python deliberately lumps modified and released dispositions into the 
> on_released callback. There is no on_modified callback.
> system_tests.py and system_tests_multicast.py mistakenly add an on_modifed 
> callback that does not override anything and is never called by proton.
> See https://issues.apache.org/jira/browse/PROTON-2180



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to