Github user ddebrunner commented on a diff in the pull request:

    https://github.com/apache/incubator-quarks/pull/60#discussion_r58104881
  
    --- Diff: 
spi/topology/src/main/java/quarks/topology/spi/graph/ConnectorStream.java ---
    @@ -163,6 +175,100 @@ protected Graph graph() {
         }
         
         @Override
    +    public <J, U, K> TStream<J> join(Function<T, K> keyer,
    +            TWindow<U, K> twindow, BiFunction<T, List<U>, J> joiner) {
    +        
    +        if(twindow instanceof TWindowImpl){
    +            TStream<U> lastStream = twindow.feeder();
    --- End diff --
    
    There's several lines of code that are common between the two 
implementations, can they be shared?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to