Github user ddebrunner commented on a diff in the pull request:
https://github.com/apache/incubator-quarks/pull/59#discussion_r58107906
--- Diff:
api/execution/src/main/java/quarks/execution/services/ControlService.java ---
@@ -91,4 +93,18 @@ Licensed to the Apache Software Foundation (ASF) under
one
* Unregister a control bean registered by {@link
#registerControl(String, String, String, Class, Object)}
*/
void unregister(String controlId);
+
+ /**
+ * Return the controls registered with this service which implement
+ * the specified interface. The interface had previously been used to
+ * {@linkplain ControlService#registerControl(String, String, String,
Class, Object) register}
+ * the control.
+ *
+ * @param controlInterface
+ * Public interface identifying the controls to be
retrieved.
+ * @return a set containing the controls registered with the given
+ * interface. If no control satisfies the query, an empty
+ * set is returned.
+ */
+ <T> Set<T> queryInterfaces(Class<T> controlInterface);
--- End diff --
It's not a 'query', it's just a 'get' (read its description). Rename to
'getControls' or 'getControlMBeans'??
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
