Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/13#discussion_r66370231
--- Diff: cli/CMakeLists.txt ---
@@ -30,6 +30,12 @@ if(LIBNUMA_FOUND)
set(QUICKSTEP_HAVE_LIBNUMA TRUE)
endif()
+if (BUILD_SHARED_LIBS)
+ set(GFLAGS_LIB_NAME gflags_nothreads-shared)
+else()
+ set(GFLAGS_LIB_NAME gflags_nothreads-static)
+endif()
--- End diff --
FYI, I've used both `gflags` and `glog` as git submodules for a private
repo, with the condition `NOT TARGET gflags_nothreads-static` to choose whether
compile `gflags`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
