Github user hbdeshmukh commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/14#discussion_r66641640
--- Diff: cli/CommandExecutor.cpp ---
@@ -194,11 +198,14 @@ void executeDescribeTable(
/**
* @brief A helper function that executes a SQL query to obtain a scalar
result.
*/
-inline TypedValue executeQueryForSingleResult(const std::string
&query_string,
- StorageManager
*storage_manager,
- QueryProcessor
*query_processor,
- SqlParserWrapper
*parser_wrapper,
- Foreman *foreman) {
+inline TypedValue executeQueryForSingleResult(
+ const tmb::client_id main_thread_client_id,
+ const tmb::client_id foreman_client_id,
--- End diff --
Same as the InsertDestination comment, the ordering is really not that
important here. If the doxygen is correct and the call sites follow the same
order of arguments, we shouldn't be too bothered about it IMHO.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
