Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/24#discussion_r66644724
--- Diff: CMakeLists.txt ---
@@ -500,9 +500,13 @@ if(USE_TCMALLOC)
# as some generators, e.g. Ninja, may need it to build properly
# BUILD_BYPRODUCTS <INSTALL_DIR>/lib/libtcmalloc_minimal.a
)
- # Static libtcmalloc_minimal.a
- add_library(libtcmalloc_minimal STATIC IMPORTED)
- set_property(TARGET libtcmalloc_minimal PROPERTY IMPORTED_LOCATION
${CMAKE_CURRENT_BINARY_DIR}/third_party/gperftools/lib/libtcmalloc_minimal.a)
+ if (BUILD_SHARED_LIBS)
+ add_library(libtcmalloc_minimal SHARED IMPORTED)
+ set_property(TARGET libtcmalloc_minimal PROPERTY IMPORTED_LOCATION
${CMAKE_CURRENT_BINARY_DIR}/third_party/gperftools/lib/libtcmalloc_minimal.so)
+ else()
+ add_library(libtcmalloc_minimal STATIC IMPORTED)
+ set_property(TARGET libtcmalloc_minimal PROPERTY IMPORTED_LOCATION
${CMAKE_CURRENT_BINARY_DIR}/third_party/gperftools/lib/libtcmalloc_minimal.a)
--- End diff --
It seems that we could move this line out of the `if-else` statement.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
