[GitHub] incubator-quickstep issue #25: Move createNewBlock() out of the critical sec...

[navsan]

Github user navsan commented on the issue:

    https://github.com/apache/incubator-quickstep/pull/25
  
    I mean, should I do it for all of them, or just some of the more commonly 
used ones? And can I be sure that createNewBlock() doesn’t need to be in the 
critical section for all of them? Do we currently use all of them in our code?
    
    Should it be in the same PR or leave that as an issue for later? 
    
    Thanks Zuyu!
    
    
    > On Jun 10, 2016, at 22:35, Zuyu ZHANG <notificati...@github.com> wrote:
    > 
    > Just search the same function name in the same file.
    > 
    > —
    > You are receiving this because you were mentioned.
    > Reply to this email directly, view it on GitHub 
<https://github.com/apache/incubator-quickstep/pull/25#issuecomment-225334475>, 
or mute the thread 
<https://github.com/notifications/unsubscribe/ACZB6wzItdfCBZb61vhfSlpKZt9da6pXks5qKi0IgaJpZM4IzdWM>.
    > 
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---