Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/28#discussion_r66737198
--- Diff: cli/QuickstepCli.cpp ---
@@ -430,6 +445,13 @@ int main(int argc, char* argv[]) {
reset_parser = true;
break;
}
+#ifdef QUICKSTEP_ENABLE_GOOGLE_PROFILER
+ // Profile only if profile_file_name flag is set
+ if (!started_profiling &&
!quickstep::FLAGS_profile_file_name.empty()) {
--- End diff --
Now we are using the singleton design pattern.
I still have a question: why we start profiling after one query finishes
execution, instead of before any query starts? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
