Hi Harshad I’m just kicking off this discussion based on a conversation I had with Jignesh this morning. We have 3 different implementations of InsertDestination, and I think we only really need one, the PartitionAwareBlockPoolInsertDestination. The AlwaysCreateBlockInsertDestination seems to be entirely useless practically. I’m guessing it’s a relic of early development. The normal BlockPoolInsertDestination seems like a degenerate case of the PartitionAware one, with a single partition.
If my understanding of the design is right, then we should refactor this code to only have one InsertDestination. There is a lot of duplication of code and complex logic in there. Anything we can do to simplify and clean up the code is probably a good move. Thoughts? Cheers, Navneet
